Skip to content

feat(aiplatform): add gemma2 samples for Model Garden deployments to VertexAI endpoints #9527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Sep 27, 2024
Merged

feat(aiplatform): add gemma2 samples for Model Garden deployments to VertexAI endpoints #9527

merged 11 commits into from
Sep 27, 2024

Conversation

TetyanaYahodska
Copy link
Contributor

@TetyanaYahodska TetyanaYahodska commented Sep 20, 2024 •
edited by rsamborski
Loading

Description

Fixes b/367768115

Canonical sample: GoogleCloudPlatform/python-docs-samples#12598

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@product-auto-label product-auto-label bot added api: aiplatform Issues related to the AI Platform API. samples Issues that are directly related to samples. labels Sep 20, 2024
@TetyanaYahodska TetyanaYahodska added the kokoro:run Add this label to force Kokoro to re-run the tests. label Sep 20, 2024
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Sep 20, 2024
@TetyanaYahodska TetyanaYahodska added the kokoro:run Add this label to force Kokoro to re-run the tests. label Sep 20, 2024
@TetyanaYahodska TetyanaYahodska marked this pull request as ready for review September 20, 2024 13:05
@snippet-bot Snippet Bot
Copy link

snippet-bot bot commented Sep 20, 2024 •
edited
Loading

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

rsamborski
rsamborski requested changes Sep 24, 2024
View reviewed changes
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Sep 25, 2024
rsamborski
rsamborski requested changes Sep 26, 2024
View reviewed changes
@TetyanaYahodska TetyanaYahodska added the kokoro:run Add this label to force Kokoro to re-run the tests. label Sep 26, 2024
Sita04
Sita04 requested changes Sep 26, 2024
View reviewed changes
@Sita04 Sita04 changed the title feat(aiplatform): add generativeaionvertexai gemma2 predict gpu and generativeaionvertexai gemma2 predict tpu samples feat(aiplatform): add gemma2 samples for Model Garden deployments to VertexAI endpoints Sep 26, 2024
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Sep 26, 2024
@TetyanaYahodska TetyanaYahodska added the kokoro:run Add this label to force Kokoro to re-run the tests. label Sep 26, 2024
@rsamborski rsamborski mentioned this pull request Sep 27, 2024
Merged
4 tasks
@rsamborski rsamborski merged commit 39ee185 into main Sep 27, 2024
11 checks passed
@rsamborski rsamborski deleted the generativeaionvertexai_gemma2_predict_gpu branch September 27, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rsamborski rsamborski rsamborski approved these changes

@Sita04 Sita04 Sita04 approved these changes

@yoshi-approver yoshi-approver Awaiting requested review from yoshi-approver yoshi-approver is a code owner

Assignees

@Mukamik Mukamik

@Sita04 Sita04

Labels

api: aiplatform Issues related to the AI Platform API. kokoro:run Add this label to force Kokoro to re-run the tests. samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@TetyanaYahodska @rsamborski @Sita04 @Mukamik @kokoro-team